Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix apt issues [DI-358] [5.5.z] #248

Merged
merged 4 commits into from
Dec 1, 2024
Merged

Fix apt issues [DI-358] [5.5.z] #248

merged 4 commits into from
Dec 1, 2024

Conversation

`apt install` prompts for confirmation, which caused the job to fail
when not specified - with the newly added option, this is avoided.

Note that I do not understand why this is only _now_ causing a problem,
as recent changes do not explain it:
- #220
   - I can reproduce this issue with both `apt-get` and `apt`
- #241
   - I can reproduce this issue with both Ubuntu and Debian

I think it should _always_ have failed.

Fixes: [DI-358](https://hazelcast.atlassian.net/browse/DI-358)

[DI-358]:
https://hazelcast.atlassian.net/browse/DI-358?atlOrigin=eyJpIjoiNWRkNTljNzYxNjVmNDY3MDlhMDU5Y2ZhYzA5YTRkZjUiLCJwIjoiZ2l0aHViLWNvbS1KU1cifQ
@JackPGreen JackPGreen self-assigned this Nov 28, 2024
When doing [a
build](https://github.com/hazelcast/hazelcast-packaging/actions/runs/10328301478/job/28594672466),
a warning is displayed:
> WARNING: apt does not have a stable CLI interface. Use with caution in
scripts.

Migrates `apt` -> `apt-get` to address this.

[Further reading](https://askubuntu.com/a/990838).
As in #245, the
[same scenario exists for `apt
remove`](#245 (comment)).

Note that this is [not required for `apt
update`](https://askubuntu.com/a/976083).
@JackPGreen JackPGreen changed the title Fix Install Hazelcast from deb's apt install [DI-358] [5.5.z] Fix apt issues [DI-358] [5.5.z] Nov 30, 2024
@JackPGreen JackPGreen requested a review from nishaatr November 30, 2024 19:32
@JackPGreen JackPGreen merged commit 0642fcf into 5.5.z Dec 1, 2024
11 of 15 checks passed
@JackPGreen JackPGreen deleted the DI-358-5.5.z branch December 1, 2024 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants