Merged
Conversation
JackPGreen
approved these changes
May 14, 2025
Contributor
There was a problem hiding this comment.
The enterprise tests in the compatibility repo fail because of the outdated test artifact. This PR replaces that with a new one.
Can we automate the updating in a similar way to hazelcast/hazelcast-nodejs-client#1535?
Can you link to the test failure, please?
In any case, in-date certificates > out-of-date certificates.
EDIT - test failure.
Contributor
|
Also I can see there's an action to do this automatically that's now failing. |
ihsandemir
approved these changes
May 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The enterprise tests in the compatibility repo fail because of the outdated test artifact.
This PR replaces that with a new one.