Skip to content

Remove Python 2 remnants #1865

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
dlech merged 1 commit into from
Nov 29, 2025
Merged

Remove Python 2 remnants #1865

dlech merged 1 commit into from
Nov 29, 2025

Conversation

@gudnimg
Copy link
Contributor

@gudnimg gudnimg commented Nov 29, 2025 •
edited
Loading

  1. There is no need to set file encoding unless its not utf-8 (See https://docs.python.org/3/reference/lexical_analysis.html#encoding-declarations)
  2. Calls to super() may omit the class name in Python 3. On Python 2 these were required.

No change in functionality.

@gudnimg
Remove Python 2 remnants
fe34ef3 
1. There is no need to set file encoding unless its not utf-8
2. Class definitions may omit (object) in Python 3
@gudnimg gudnimg force-pushed the gudni-python2-cleanup branch from 1cc3aec to fe34ef3 Compare November 29, 2025 17:40
@gudnimg
Copy link
Contributor Author

gudnimg commented Nov 29, 2025

Rebased, pushed formatting fixes for CI.

@dlech dlech merged commit 4aacc2f into hbldh:develop Nov 29, 2025
16 checks passed
@dlech
Copy link
Collaborator

dlech commented Nov 29, 2025

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gudnimg @dlech