Skip to content

Commit

Permalink
Merge pull request #56 from raultcj/master
Browse files Browse the repository at this point in the history
Now allow user to add country and platform as a parameter when reques…
  • Loading branch information
hborras authored Apr 5, 2019
2 parents 44215e3 + f007228 commit 42dd840
Showing 1 changed file with 11 additions and 0 deletions.
11 changes: 11 additions & 0 deletions src/TwitterAds/Analytics.php
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
use Hborras\TwitterAdsSDK\TwitterAds\Analytics\Job;
use Hborras\TwitterAdsSDK\TwitterAds\Errors\BadRequest;
use Hborras\TwitterAdsSDK\TwitterAds\Fields\AnalyticsFields;
use Hborras\TwitterAdsSDK\TwitterAds\Fields\JobFields;

class Analytics extends Resource
{
Expand Down Expand Up @@ -43,6 +44,8 @@ public function all_stats($ids, $metricGroups, $params = [], $async = false)
throw new BadRequest('Entity must be one of ACCOUNT,FUNDING_INSTRUMENT,CAMPAIGN,LINE_ITEM,PROMOTED_TWEET,ORGANIC_TWEET', 500, []);
}
$segmentationType = isset($params[AnalyticsFields::SEGMENTATION_TYPE]) ? $params[AnalyticsFields::SEGMENTATION_TYPE] : null;
$country = isset($params[JobFields::COUNTRY]) ? $params[JobFields::COUNTRY] : null;
$platform = isset($params[JobFields::PLATFORM]) ? $params[JobFields::PLATFORM] : null;

$params = [
AnalyticsFields::METRIC_GROUPS => implode(",", $metricGroups),
Expand All @@ -64,6 +67,14 @@ public function all_stats($ids, $metricGroups, $params = [], $async = false)
$params[AnalyticsFields::SEGMENTATION_TYPE] = $segmentationType;
}

if (!is_null($country)) {
$params[JobFields::COUNTRY] = $country;
}

if (!is_null($platform)) {
$params[JobFields::PLATFORM] = $platform;
}

$resource = str_replace(static::RESOURCE_REPLACE, $this->getTwitterAds()->getAccountId(), static::RESOURCE_STATS_JOBS);
$response = $this->getTwitterAds()->post($resource, $params);
$job = new Job();
Expand Down

0 comments on commit 42dd840

Please sign in to comment.