Merge pull request #63 from hborras/v5

V5
hborras · Aug 20, 2019 · f1984f9 · f1984f9
2 parents 600f6d9 + 0cc0349
commit f1984f9
Show file tree

Hide file tree

Showing 15 changed files with 11 additions and 50 deletions.
diff --git a/src/TwitterAds.php b/src/TwitterAds.php
@@ -21,7 +21,7 @@
  */
 class TwitterAds extends Config
 {
-    const API_VERSION      = '4';
+    const API_VERSION      = '5';
     const API_REST_VERSION = '1.1';
     const API_HOST = 'https://ads-api.twitter.com';
     const API_HOST_SANDBOX = 'https://ads-api-sandbox.twitter.com';

diff --git a/src/TwitterAds/Campaign/TargetingCriteria.php b/src/TwitterAds/Campaign/TargetingCriteria.php
@@ -42,7 +42,7 @@ class TargetingCriteria extends Resource
      */
     public function line_item_all($line_item_id, $params = [])
     {
-        $params[TargetingCriteriaFields::LINE_ITEM_ID] = $line_item_id;
+        $params[TargetingCriteriaFields::LINE_ITEM_IDS] = [$line_item_id];
 
         $resource = str_replace(static::RESOURCE_REPLACE, $this->getTwitterAds()->getAccountId(), static::RESOURCE_COLLECTION);
         $request = $this->getTwitterAds()->get($resource, $params);

diff --git a/src/TwitterAds/Creative/ImageAppDownloadCard.php b/src/TwitterAds/Creative/ImageAppDownloadCard.php
@@ -12,7 +12,6 @@ class ImageAppDownloadCard extends Resource
 
     /** Read Only */
     protected $id;
-    protected $preview_url;
     protected $created_at;
     protected $updated_at;
     protected $deleted;
@@ -50,14 +49,6 @@ public function getId()
         return $this->id;
     }
 
-    /**
-     * @return mixed
-     */
-    public function getPreviewUrl()
-    {
-        return $this->preview_url;
-    }
-
     /**
      * @return mixed
      */

diff --git a/src/TwitterAds/Creative/ImageConversationCard.php b/src/TwitterAds/Creative/ImageConversationCard.php
@@ -12,7 +12,6 @@ class ImageConversationCard extends Resource
 
     /** Read Only */
     protected $id;
-    protected $preview_url;
     protected $created_at;
     protected $updated_at;
     protected $deleted;
@@ -48,14 +47,6 @@ public function getId()
         return $this->id;
     }
 
-    /**
-     * @return mixed
-     */
-    public function getPreviewUrl()
-    {
-        return $this->preview_url;
-    }
-
     /**
      * @return mixed
      */

diff --git a/src/TwitterAds/Creative/VideoAppDownloadCard.php b/src/TwitterAds/Creative/VideoAppDownloadCard.php
@@ -12,7 +12,6 @@ class VideoAppDownloadCard extends Resource
 
     /** Read Only */
     protected $id;
-    protected $preview_url;
     protected $video_url;
     protected $video_poster_url;
     protected $created_at;
@@ -54,14 +53,6 @@ public function getId()
         return $this->id;
     }
 
-    /**
-     * @return mixed
-     */
-    public function getPreviewUrl()
-    {
-        return $this->preview_url;
-    }
-
     /**
      * @return mixed
      */

diff --git a/src/TwitterAds/Creative/VideoConversationCard.php b/src/TwitterAds/Creative/VideoConversationCard.php
@@ -12,7 +12,6 @@ class VideoConversationCard extends Resource
 
     /** Read Only */
     protected $id;
-    protected $preview_url;
     protected $video_url;
     protected $video_poster_url;
     protected $created_at;
@@ -52,14 +51,6 @@ public function getId()
         return $this->id;
     }
 
-    /**
-     * @return mixed
-     */
-    public function getPreviewUrl()
-    {
-        return $this->preview_url;
-    }
-
     /**
      * @return mixed
      */

diff --git a/src/TwitterAds/Fields/CampaignFields.php b/src/TwitterAds/Fields/CampaignFields.php
@@ -25,6 +25,7 @@ class CampaignFields extends Fields
     const SORT_BY                         = 'sort_by';
     const ENTITY_STATUS                   = 'entity_status';
     const WITH_TOTAL_COUNT                = 'with_total_count';
+    const WITH_DRAFT                      = 'with_draft';
 
     const ACCOUNT_ID = 'account_id';
     const CAMPAIGN_IDS                    = 'campaign_ids';

diff --git a/src/TwitterAds/Fields/ImageAppDownloadCardFields.php b/src/TwitterAds/Fields/ImageAppDownloadCardFields.php
@@ -8,7 +8,6 @@ class ImageAppDownloadCardFields
     const CREATED_AT              = 'created_at';
     const UPDATED_AT              = 'updated_at';
     const DELETED                 = 'delete';
-    const PREVIEW_URL             = 'preview_url';
     const NAME                    = 'name';
     const COUNTRY_CODE        = 'country_code';
     const IPHONE_APP_ID           = 'iphone_app_id';

diff --git a/src/TwitterAds/Fields/ImageConversationCardFields.php b/src/TwitterAds/Fields/ImageConversationCardFields.php
@@ -8,7 +8,6 @@ class ImageConversationCardFields
     const CREATED_AT       = 'created_at';
     const UPDATED_AT       = 'updated_at';
     const DELETED          = 'delete';
-    const PREVIEW_URL      = 'preview_url';
     const NAME             = 'name';
     const TITLE            = 'title';
     const FIRST_CTA        = 'first_cta';

diff --git a/src/TwitterAds/Fields/LineItemFields.php b/src/TwitterAds/Fields/LineItemFields.php
@@ -31,11 +31,12 @@ class LineItemFields
     const SORT_BY                         = 'sort_by';
     const ENTITY_STATUS                   = 'entity_status';
     const WITH_TOTAL_COUNT                = 'with_total_count';
-    const TARGET_CPA_LOCAL_MICRO = 'target_cpa_local_micro';
-    const CATEGORIES = 'categories';
-    const CURRENCY = 'currency';
-    const TRACKING_TAGS = 'tracking_tags';
-    const LOOKALIKE_EXPANSION = 'lookalike_expansion';
+    const TARGET_CPA_LOCAL_MICRO          = 'target_cpa_local_micro';
+    const CATEGORIES                      = 'categories';
+    const CURRENCY                        = 'currency';
+    const TRACKING_TAGS                   = 'tracking_tags';
+    const LOOKALIKE_EXPANSION             = 'lookalike_expansion';
+    const WITH_DRAFT                      = 'with_draft';
 
     const CAMPAIGN_IDS = 'campaign_ids';
     const FUNDING_INSTRUMENT_IDS = 'funding_instrument_ids';

diff --git a/src/TwitterAds/Fields/TargetingCriteriaFields.php b/src/TwitterAds/Fields/TargetingCriteriaFields.php
@@ -11,6 +11,7 @@ class TargetingCriteriaFields
     const UPDATED_AT                  = 'updated_at';
     const DELETED                     = 'delete';
     const LINE_ITEM_ID                = 'line_item_id';
+    const LINE_ITEM_IDS               = 'line_item_ids';
     const TARGETING_TYPE              = 'targeting_type';
     const TARGETING_VALUE             = 'targeting_value';
     const TAILORED_AUDIENCE_EXPANSION = 'tailored_audience_expansion';

diff --git a/src/TwitterAds/Fields/VideoAppDownloadCardFields.php b/src/TwitterAds/Fields/VideoAppDownloadCardFields.php
@@ -8,11 +8,10 @@ class VideoAppDownloadCardFields
     const CREATED_AT           = 'created_at';
     const UPDATED_AT           = 'updated_at';
     const DELETED              = 'delete';
-    const PREVIEW_URL          = 'preview_url';
     const VIDEO_URL            = 'video_url';
     const VIDEO_POSTER_URL     = 'video_poster_url';
     const NAME                 = 'name';
-    const COUNTRY_CODE     = 'country_code';
+    const COUNTRY_CODE         = 'country_code';
     const IPHONE_APP_ID        = 'iphone_app_id';
     const IPHONE_DEEP_LINK     = 'iphone_deep_link';
     const IPAD_APP_ID          = 'ipad_app_id';

diff --git a/src/TwitterAds/Fields/VideoConversationCardFields.php b/src/TwitterAds/Fields/VideoConversationCardFields.php
@@ -10,7 +10,6 @@ class VideoConversationCardFields
     const DELETED          = 'delete';
     const VIDEO_URL        = 'video_url';
     const VIDEO_POSTER_URL = 'video_poster_url';
-    const PREVIEW_URL      = 'preview_url';
     const NAME             = 'name';
     const TITLE            = 'title';
     const FIRST_CTA        = 'first_cta';

diff --git a/src/TwitterAds/Fields/VideoFields.php b/src/TwitterAds/Fields/VideoFields.php
@@ -12,7 +12,6 @@ class VideoFields
     const READY_TO_TWEET       = 'ready_to_tweet';
     const DURATION             = 'duration';
     const REASONS_NOT_SERVABLE = 'reasons_not_servable';
-    const PREVIEW_URL          = 'preview_url';
     const TITLE                = 'title';
     const DESCRIPTION          = 'description';
     const VIDEO_MEDIA_ID       = 'video_media_id';

diff --git a/src/TwitterAds/Fields/WebsiteCardFields.php b/src/TwitterAds/Fields/WebsiteCardFields.php
@@ -9,7 +9,6 @@ class WebsiteCardFields
     const CREATED_AT         = 'created_at';
     const UPDATED_AT         = 'updated_at';
     const DELETED            = 'deleted';
-    const PREVIEW_URL        = 'preview_url';
     const WEBSITE_TITLE      = 'website_title';
     const WEBSITE_URL        = 'website_url';
     const IMAGE_MEDIA_ID     = 'image_media_id';