Fixing emulator bug #391 #392
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SumolX
reviewed
Jan 31, 2024
SumolX
reviewed
Jan 31, 2024
SumolX
reviewed
Jan 31, 2024
SumolX
reviewed
Jan 31, 2024
SumolX
reviewed
Jan 31, 2024
|
Thanks for the review, all changes were added.. |
|
@lukolszewski Build firmware failed. Please fix this. |
|
@lukolszewski Is the PR abandoned? If not please do update the branch and we can get it merged into main. Thank You. |
|
I went ahead and fixed this over at #428 so please have a look there 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The emulator would crash for me. This is either because SDL was not initialised before SDL_WaitEvent was called, or more likely because anothe thread was trying to use SDL at the same time. This fixes both by initialising SDL earlier and by setting up a mutex that locks access to SDL when the input thread works.
This affects the emulator only, it has no impact on running on the goggles