-
Notifications
You must be signed in to change notification settings - Fork 210
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
frontend: Add CronJobListView
story to test cronstrue
dependency
#2812
base: main
Are you sure you want to change the base?
Conversation
e4051e1
to
052946a
Compare
Hi, thanks for opening a PR! Make sure the tests are passing and you use atomic commits |
CronJob
storyCronJobListView
story
CronJobListView
storyCronJobListView
story to test cronstrue
dependency
a75b21b
to
aaf8fc6
Compare
Hi @sniok I have updated the PR title and description and now following atomic commits as per the guidelines. Also I have made sure that the tests and linting are passing. Please let me know if anything else. Thanks. |
Thanks for updating it other than that the PR looks good! |
Ohh. Yes. I did see it getting generated but I thought it wasn't necessary to be attached over here but anyways I will do it. Thanks. |
6cb8bcd
to
7b98437
Compare
Hi @sniok. Can you also re-review this one? Thanks. |
Also, do you think we should write e2e tests for this? or just this storybook is fine? The original issue mentioned either one is fine. So just confirming once from your side. |
or I could open one more PR for the e2e tests. That's fine with me. |
e2e tests are separate, so just storybook is fine |
Signed-off-by: adwait-godbole <[email protected]>
7b98437
to
540774c
Compare
Done! |
Fixes #2374
Screencast.from.2025-01-30.19-12-59.webm
@illume can you please review this PR. Thanks.