Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

frontend: Add clusterChooser componnent stories #2823

Merged
merged 1 commit into from
Feb 7, 2025

Conversation

Faakhir30
Copy link
Contributor

References #931

Added clusterChooser components stories.

Here's storybook video of current state:
Screencast from 2025-02-01 03-55-16.webm

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jan 31, 2025
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for opening a PR for this! This looks good, just needs a couple of small changes

@Faakhir30 Faakhir30 force-pushed the feat/cluster-chooser-stories branch from 62ca937 to 2f97f30 Compare February 4, 2025 00:26
@Faakhir30 Faakhir30 requested a review from sniok February 4, 2025 15:07
Copy link
Contributor

@sniok sniok left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice, thanks!

Copy link
Collaborator

@illume illume left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 🎈

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Feb 7, 2025
@illume illume merged commit 9aaa1dd into headlamp-k8s:main Feb 7, 2025
15 checks passed
@Faakhir30 Faakhir30 deleted the feat/cluster-chooser-stories branch February 7, 2025 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants