Merge pull request #3 from mateuszm-arianelabs/CCS-37-non-zero-token-…

…holders FIX: feat: add accepting TokenId as input, filter out zero balances (CCS-37)
hedera-dev · Jan 30, 2025 · ca636f7 · ca636f7
2 parents 47a5474 + 061a8e0
commit ca636f7
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 5 deletions.
diff --git a/src/agent/index.ts b/src/agent/index.ts
@@ -83,11 +83,11 @@ export default class HederaAgentKit {
   }
 
   async getTokenHolders(
-      tokenId: string,
+      tokenId: string | TokenId,
       networkType: HederaNetworkType,
       threshold?: number,
   ): Promise<Array<TokenBalance>> {
-    return get_token_holders(tokenId, networkType, threshold);
+    return get_token_holders(tokenId.toString(), networkType, threshold);
   }
 
   async associateToken(

diff --git a/src/tools/hts/queries/holders.ts b/src/tools/hts/queries/holders.ts
@@ -14,10 +14,9 @@ export const get_token_holders = async (
     let baseUrl = createBaseMirrorNodeApiUrl(networkType)
 
     // 100 results at once, endpoint data updated each 15min
-    let url: string | null = threshold
+    let url: string | null = threshold !== undefined
         ? `${baseUrl}/api/v1/tokens/${tokenId}/balances?limit=100&account.balance=gte%3A${threshold}`
-        : `${baseUrl}/api/v1/tokens/${tokenId}/balances?limit=100`;
-
+        : `${baseUrl}/api/v1/tokens/${tokenId}/balances?limit=100&account.balance=gt%3A0`;           // if no threshold set filter out wallets with 0 balances
 
     const array = new Array<TokenBalance>();