fix h:uri.action viewhelper - $uriBuilder->setRequest($request)

[TrueType]

Hi Helmut,
please merge this little change. I still use the viewhelper for AJAX uri generation in some projects. It is simple and straightforward. The missing request object with the uribuilder prevents it from working with TYPO3v12. Thx.
Henri Nathanson

[wazum]

This change results in an exception now:

TYPO3\CMS\Extbase\Mvc\Web\Routing\UriBuilder::setRequest(): Argument #1 ($request) must be of type TYPO3\CMS\Extbase\Mvc\RequestInterface, TYPO3\CMS\Core\Http\ServerRequest given, called in /var/www/html/vendor/helhum/typoscript-rendering/Classes/Uri/TyposcriptRenderingUri.php on line 85

[TrueType]

Hmm. This probably comes with that one - https://docs.typo3.org/c/typo3/cms-core/main/en-us/Changelog/12.0/Breaking-98377-FluidStandaloneViewDoesNotCreateAnExtbaseRequestAnymore.html

[wazum]

We had this patch in place with the previous commit … all half-baked solutions.

diff --git a/Classes/Uri/TyposcriptRenderingUri.php b/Classes/Uri/TyposcriptRenderingUri.php
index 6f8b34d0..a75a7299 100644
--- a/Classes/Uri/TyposcriptRenderingUri.php
+++ b/Classes/Uri/TyposcriptRenderingUri.php
@@ -65,9 +65,9 @@ class TyposcriptRenderingUri extends Uri
             $extensionName = $request->getControllerExtensionName();
         }
         if ($contextRecord === 'current') {
-            if (
-                $pluginName !== $request->getPluginName()
-                || $extensionName !== $request->getControllerExtensionName()
+            if ($request instanceof \TYPO3\CMS\Extbase\Mvc\Request &&
+               ($pluginName !== $request->getPluginName() ||
+               $extensionName !== $request->getControllerExtensionName())
             ) {
                 $contextRecord = 'currentPage';
             } else {
@@ -132,9 +132,9 @@ class TyposcriptRenderingUri extends Uri
             $extensionName = $request->getWidgetContext()->getParentExtensionName();
         }
         if ($contextRecord === 'current') {
-            if (
-                $pluginName !== $request->getWidgetContext()->getParentPluginName()
-                || $extensionName !== $request->getWidgetContext()->getParentExtensionName()
+            if ($request instanceof \TYPO3\CMS\Extbase\Mvc\Request &&
+                ($pluginName !== $request->getPluginName() ||
+                $extensionName !== $request->getControllerExtensionName())
             ) {
                 $contextRecord = 'currentPage';
             } else {

[TrueType]

I have seen these fixes. I decided to not go that way, because it seemed not clean enough I created plugins and rendered them with <f:cObject typoscriptObjectPath="lib.xy">. I have depencies here between an EXT:sitepackage and EXT:my_extbase_business ...

[TrueType]

Sry, if I messed things up here. I used the extension to create AJAX uris. That may have never been the intended use of this extension. I switched to typeNum uris instead.
{f:uri.action('pageType:'<your_typenum>',controller:'xy',action:'xy')}
The typoscript definition can use a USER_INT. So in case you have only non-cached AJAX calls, one can omit the double declaration within ext_localconf.php -> configurePlugin().