New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix flask-smorest quoting #8

Closed

bodik wants to merge 2 commits into helloflask:main from bodik:feature-flasksmorest2

Contributor

bodik commented Nov 28, 2023

fix flask-smorest quoting


          flask-smorest: fix quoting (use no quotes)

edaf38e

bodik changed the title ~~WIP: fix flask-smorest quoting~~ fix flask-smorest quoting

Contributor Author

bodik commented Nov 28, 2023

a little trick for quoting which fixes flas-smorest extension workflow

Member

greyli commented Nov 29, 2023

You can use quote to escape quote: https://github.com/greyli/flask-extension-status/blob/main/extensions.yml#L64


          flask-smorest: fix quoting (use more quotes)

734d786

Contributor Author

bodik commented Nov 29, 2023 •

edited

Loading

You can use quote to escape quote: https://github.com/greyli/flask-extension-status/blob/main/extensions.yml#L64

Does not seem so, I've been there yesterday
https://github.com/greyli/flask-extension-status/actions/runs/7029417573/workflow

let's drop the '' and go on with str ?

Member

greyli commented Nov 29, 2023 •

edited

Loading

It turns out we should add the "|" to the command to make sure the whole line can be read as a complete string. Fixed in https://github.com/greyli/flask-extension-status/pull/9/files#diff-73ed4e9979da612f5b529fdca94a62445696b9eb6195b2705199114983957f30R28

greyli closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet