feat: broad improvments #33
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Jun 21, 2021
Nytelife26
force-pushed
the
chore/squeeze-jit
branch
3 times, most recently
from
028413d to
a31b3c1
Compare
Nytelife26
force-pushed
the
chore/squeeze-jit
branch
5 times, most recently
from
8fe559a to
c7ea117
Compare
Nytelife26
force-pushed
the
chore/squeeze-jit
branch
2 times, most recently
from
109a0b2 to
f2bb1d4
Compare
Nytelife26
force-pushed
the
chore/squeeze-jit
branch
from
f2bb1d4 to
2f492ba
Compare
Nytelife26
force-pushed
the
chore/squeeze-jit
branch
from
2f492ba to
50dfb60
Compare
|
This pull request introduces 1 alert when merging 1103604 into b9f24f9 - view on LGTM.com new alerts:
|
axisiscool
suggested changes
Oct 15, 2021
| else val[val.length] = toA; | ||
| } else this.headers[key] = toA; | ||
| // eslint-disable-next-line @typescript-eslint/no-unnecessary-boolean-literal-compare, max-len, no-unused-expressions, max-statements-per-line, eqeqeq | ||
| if (val !== undefined) if (Array.isArray(val) == false) (this.headers[key] = [val, toA]); else (val[val.length] = toA); |
There was a problem hiding this comment.
Strict equality isn't necessary here:
Suggested change
| if (val !== undefined) if (Array.isArray(val) == false) (this.headers[key] = [val, toA]); else (val[val.length] = toA); | |
| if (val != undefined) if (Array.isArray(val) == false) (this.headers[key] = [val, toA]); else (val[val.length] = toA); |
There was a problem hiding this comment.
@tbnritzdoge didn't we work out that strict equality ended up being faster in this instance?
There was a problem hiding this comment.
i thought we found out the opposite
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.