Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle optgroups #18

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Handle optgroups #18

wants to merge 1 commit into from

Conversation

obojdi
Copy link

@obojdi obojdi commented Apr 1, 2016

data-i for index in each optgroup

costellos2010
costellos2010 approved these changes Jun 5, 2017
View reviewed changes
Copy link

@costellos2010 costellos2010 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works very well. I approve these changes, and think they should be added. Only thing left to mention is you need to add some styling to the div.optgroup and the > span.

@tiunov80
Copy link

tiunov80 commented Nov 12, 2018 •
edited
Loading

Hello, any updates regarding optgroup ?

@aleare-design
Copy link

aleare-design commented Mar 26, 2019 •
edited
Loading

Hi, I've found that if you have more than an option group DIVS get nested, DIVS should work separately from each other filtering these div groups by optiongroup label, but I can't find out how to make it work.
Any ideas?

@GiorgosK GiorgosK mentioned this pull request Feb 2, 2020
Open
@GiorgosK
Copy link

GiorgosK commented Feb 2, 2020

With #96 solving the problem of nested optgroup when the data-i attribute is not present

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@johnnybui johnnybui johnnybui approved these changes

@costellos2010 costellos2010 costellos2010 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@obojdi @tiunov80 @aleare-design @GiorgosK @johnnybui @costellos2010