Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Download the latest supported chromedriver for the version of Chrome installed by heroku-buildpack-google-chrome #28

Closed
wants to merge 1 commit into from

Conversation

fkztw
Copy link

@fkztw fkztw commented Sep 10, 2020

So, we can avoid the chromedriver version mismatch problem in a general situation.

The detail is in: heroku/heroku-buildpack-google-chrome#95

This PR should not be merged until the upstream repo PR been merged.

@fkztw
Copy link
Author

fkztw commented Sep 11, 2020

I encountered a problem that there might be no same version of chromedriver for Google Chrome.

As the screenshot of build log below, https://chromedriver.storage.googleapis.com/85.0.4183.102/chromedriver_linux64.zip doesn't exist. (The latest version of chromedriver is only 85.0.4183.87 at this time.)

20200911_17:28:28

Close this PR at this time until I find a way to deal with this situation.

@fkztw fkztw closed this Sep 11, 2020
@pvande
Copy link

pvande commented Oct 8, 2020

From the Chromedriver docs (http://chromedriver.chromium.org/downloads/version-selection):

Here are the steps to select the version of ChromeDriver to download:

@fkztw fkztw changed the title Download the same version chromedriver for Chrome installed by heroku-buildpack-google-chrome Download the latest supported chromedriver for the version of Chrome installed by heroku-buildpack-google-chrome Oct 11, 2020
@fkztw fkztw reopened this Oct 11, 2020
…roku-buildpack-google-chrome

So, we can avoid the chromedriver version mismatch problem in a general situation.
@fkztw fkztw force-pushed the find-same-version-as-chrome branch from 5ccfde9 to f2af368 Compare October 11, 2020 16:50
@fkztw
Copy link
Author

fkztw commented Oct 11, 2020

Works like a charm after using the new patch.
Thanks to @pvande.
Downloaded chromedriver 86.0.4240.22 for Google Chrome 86.0.4240.75.
And it works fine on my Heroku app.

20201012_00:41:35

How do I modify the CHANGELOG.md to pass the "Check changelog" GitHub Action? I know it only checks if there's diff for CHANGELOG.md. Is there any contribution guide about the format of the CHANGELOG.md? Or the maintainers will modify the CHANGELOG.md after reviewing the PR?

And just want to remind again. This PR is staled by heroku/heroku-buildpack-google-chrome#95. Should not be merged before that PR is merged.

jstvz added a commit to SFDO-Tooling/heroku-buildpack-chromedriver that referenced this pull request Jun 1, 2022
This commit updates the chromedriver buildpack to retrieve the correct
chromedriver version based on the installed version of Google Chrome.
During major releases there is a brief window where mismatching versions
can be installed. This change uses the major.minor.patch based on the
[chromedriver docs].

This change requires that heroku-buildpack-google-chrome come first in
the order of buildpacks.

For similar approaches see:

- heroku#28
- heroku#36

[chromedriver docs]: https://chromedriver.chromium.org/downloads/version-selection
@edmorley
Copy link
Member

Hi! Sorry for the delay in replying to this PR. This buildpack isn't an officially supported buildpack so maintenance has been best-effort.

This buildpack has since been replaced by a new combined Chrome+chromedriver buildpack that resolves a number of issues:
https://github.com/heroku/heroku-buildpack-chrome-for-testing

As such this buildpack is being sunset.

@edmorley edmorley closed this Apr 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants