[v3] Beta 2 #5885
[v3] Beta 2 #5885
Conversation
|
jrgarciadev
changed the title
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
…es for improved animations (#5899)
* feat: dropdown in progress * feat: add background color for accordion item and update separator component with TODO for surface colors * feat: dropdown implementation and styles completed * feat: dropdown documented
* feat(component): modal wip * docs(component): modal * fix(style): modal with form * chore(component): polish modal examples * fix(docs): animation stuttering * chore(docs): undo animation stuttering * chore(component): polish modal example * chore: animation, stories * refactor(component): modal anatomy, animations, hooks and docs * fix(component): use modal hook * chore(docs): cleanup * feat(docs): add modal component to registry and list * chore(styles): remove focus ring for dialog * chore(storybook): adjust layout for tooltip stories * fix(docs): update modal icon from preview to new --------- Co-authored-by: Junior Garcia <[email protected]>
- Add new combobox component with documentation and demos - Update dropdown, select, and listbox components - Add empty-state component - Update component registry and styles
| return ( | ||
| <ButtonPrimitive | ||
| className={composeTwRenderProps(className, styles)} | ||
| data-slot="button" |
There was a problem hiding this comment.
Bug: asChild breaks data-slot consistency.
The data-slot="button" attribute is missing from SlotPrimitive when asChild is true. This creates inconsistent behavior where the attribute is only present when asChild is false. Other components like CloseButton correctly add the data-slot attribute to both SlotPrimitive and ButtonPrimitive branches, ensuring consistent behavior regardless of the asChild prop value.
…separator - Add SurfaceContext.Provider with variant 'default' to components using bg-overlay/bg-surface: Popover, Combobox, Select, Dropdown, Alert, Modal - Enables inner components to apply 'on-surface' colors for proper contrast - Rename all divider-related CSS variables and utilities to separator: --divider → --separator, --color-divider → --color-separator, bg-divider → bg-separator, border-divider → border-separator - Updated in variables.css, theme.css, component styles, and documentation - Add new calculated variable --color-separator-on-surface for separator visibility on surface backgrounds - Update Separator component documentation with isOnSurface prop and automatic surface detection - Add breaking change documentation for divider → separator rename
|
|
||
| ### v3.0.0-beta.2 | ||
|
|
||
| **November 19, 2025** |
There was a problem hiding this comment.
Bug: Release Date Inconsistency
The release date shows November 19, 2025 in the index file but the detailed release notes at v3-0-0-beta-2.mdx show November 16, 2025 (line 7). This date inconsistency creates confusion about the actual release date.
| > | ||
| <Iconify icon="gravity-ui:sparkles" /> | ||
| <span>v{currentVersion}: Major Redesign</span> | ||
| <span>v{currentVersion}: New components</span> |
There was a problem hiding this comment.
Bug: Outdated Changelog Link
The version chip on the homepage links to /docs/changelog/v3-0-0-beta-1 but this is a beta.2 release. The link should point to /docs/changelog/v3-0-0-beta-2 to direct users to the latest release notes instead of the previous version.
* fix(style): reduce motion * fix(docs): default foreground color * fix(style): support light and default theme * fix(style): support motion reduce for pseudo elements --------- Co-authored-by: Junior Garcia <[email protected]>
- Add comprehensive NumberField documentation (number-field.mdx) - Create 13 demo components extracted from Storybook stories: * basic, with-description, required, validation, disabled * controlled, with-validation, with-step, with-format-options * custom-icons, on-surface, with-chevrons, form-example - Register NumberField in documentation system: * Add to meta.json navigation * Add to components-list.tsx * Add to components-registry.ts with relationships - Update v3.0.0-beta.2 changelog to include NumberField as 4th new component - Update demos index.ts to register all NumberField demos
| "description": "HeroUI v3 Release Notes", | ||
| "root": false, | ||
| "pages": ["changelog", "v3-0-0-beta-1"] | ||
| "pages": ["changelog", "v3-0-0-beta-2"] |
There was a problem hiding this comment.
Bug: Broken Navigation: Release Notes Are Missing
The pages array only includes v3-0-0-beta-2 but is missing v3-0-0-beta-1, which is referenced in the changelog index and linked from the homepage. This breaks navigation to the beta-1 release notes, creating a 404 error when users click the "Read full release notes" link for v3.0.0-beta.1.
| --- | ||
|
|
||
| <div className="flex items-center gap-3 mb-6"> | ||
| <span className="text-sm text-muted">November 16, 2025</span> |
There was a problem hiding this comment.
Bug: Date inconsistency in changelog files
The release date in v3-0-0-beta-2.mdx shows "November 16, 2025" but the changelog index at index.mdx line 16 shows "November 19, 2025" for the same release. This date mismatch creates confusion about the actual release date and could mislead users checking the changelog.
Closes #
📝 Description
⛳️ Current behavior (updates)
🚀 New behavior
💣 Is this a breaking change (Yes/No):
📝 Additional Information
Note
Adds five major components (AlertDialog, ComboBox, Dropdown, Modal, NumberField), renames Select.Content to Select.Popover (breaking), updates separator/theme/motion utilities, and refreshes docs/demos with supporting APIs.
AlertDialog,ComboBox,Dropdown,Modal,NumberField(React APIs, styles, Storybook, demos, docs).Select.Content→Select.Popover(updated across React, docs, demos).--divider/bg-divider→--separator/bg-separator; addseparator--on-surfaceand calculated--color-separator-on-surface.motion-reduce/motion-safe, dark class/attr precedence).useOverlayStatehook; newMenuprimitives forDropdown;SurfaceContextintegration for overlays.v3-0-0-beta-2; site-wide separator/migration updates; minor UI tweaks (spinner color, button variants).Written by Cursor Bugbot for commit 28d7298. This will update automatically on new commits. Configure here.