feat(robot): forward InternalIPs by default on Robot nodes #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whenever a user configures the `--node-ip` flag, we forward the configured IPs without validating them. This should improve Robot support for HCCM, as users now can configure private IPs for Robot nodes, like for example vSwitch IPs. This forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #865 +/- ##
==========================================
- Coverage 70.69% 70.35% -0.35%
==========================================
Files 31 31
Lines 3310 3329 +19
==========================================
+ Hits 2340 2342 +2
- Misses 795 807 +12
- Partials 175 180 +5 ☔ View full report in Codecov by Sentry. |
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
apricote
reviewed
Feb 10, 2025
Renamed ROBOT_DISABLE_FORWARD_INTERNAL_IPS -> ROBOT_FORWARD_INTERNAL_IPS
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
changed the title
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
lukasmetzner
temporarily deployed
to
e2e-robot
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whenever a user configures the
--node-ipflag, we forward the configured IPs. We validate if the IP already exists as an ExternalIP and does not collide with the configured address family. This improves the Robot support for HCCM, as users can configure private IPs for Robot nodes.Forwarding only happens during the initialization phase of HCCM and should therefore not break existing clusters.
This feature can be disabled by setting the environment variable
ROBOT_FORWARD_INTERNAL_IPStofalse.