feat(studio): flat inspector — Media group#2123
Open
vanceingalls wants to merge 7 commits into
Open
Conversation
This was referenced Jul 10, 2026
Collaborator
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jul 10, 2026
vanceingalls
changed the title
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Fourth PR in a 6-PR stack for the flat inspector redesign (see #2120 for the foundation and full stack list). Adds the
FlatToggleprimitive and the flat Media group (source/copy row, cutout sub-block, volume/rate/media-start sliders, loop/muted/has-audio-track toggles, fit/position rows), wired into the accordion.Stack: #2120 (Foundation+Text) → #2121 (Style) → #2122 (Layout+Motion) → #2123 (this) → #2124 (Grade) → #2125 (Pinning + multi-field Text).
Why
Media covers every video/audio/image-specific control (playback, cutout, fit) that doesn't belong in the more general Style/Layout groups.
How
FlatToggleis a new shared primitive (used here for loop/muted/has-audio-track, and reused by the Grade group in the next PR).FlatMediaSectioncomposes six rows/sub-blocks across playback and framing controls.STUDIO_FLAT_INSPECTOR_ENABLED(default off).Test plan
onSetHtmlAttributecalls), which required an explicit fix-round during task review to reach full coverage.oxlint/oxfmt/fallowclean.