fix(studio): widen FlatSlider's click/drag hit area vertically#2142
fix(studio): widen FlatSlider's click/drag hit area vertically#2142vanceingalls wants to merge 1 commit into
Conversation
miga-heygen
left a comment
There was a problem hiding this comment.
Reviewed as part of the 15-PR edit-panel redesign stack. Full stack review posted on #2120. No blockers on this PR. — Miga
The track's visible line was only 2px tall, and pointerdown was bound directly to that thin element, making it hard to grab. The hit area is now 20px tall (a wrapping div) with the visible line rendered as a thin decorative child, centered inside it — the ratio math only reads left/width so click accuracy is unaffected. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
miguel-heygen
left a comment
There was a problem hiding this comment.
Final current-head pass: a88b530. Reviewed the stack boundaries and current diff against the flat-inspector contracts; required checks have no failures/pending checks and no unresolved review threads remain. No new drift found; residual notes are non-blocking.
a88b530 to
fd1fb17
Compare
030243d to
fca1d7d
Compare
miguel-heygen
left a comment
There was a problem hiding this comment.
Superseding earlier approval: the latest max-review pass found confirmed correctness issues in this flat-inspector stack (identity/selector-index state, hide-all write races, timing inference, slider pointer/keyboard/reset semantics, and duplicate React keys). Hold merge and require fixes plus re-review on the current stack head.

What
Twelfth PR in the flat inspector stack (see #2120 for the foundation and full stack list). Widens
FlatSlider's click/drag hit area from 2px (matching the thin visible line) to 20px, without changing anything about how the slider looks.Stack: #2120 → ... → #2136 → #2142 (this).
Why
Requested directly after using the redesigned inspector live — the slider's clickable/draggable region was exactly as tall as its thin visual line, making it easy to miss.
How
role,aria-*attributes,onPointerDownhandler, and cursor styling that used to live on the thin line itself.left/widthfrom the target element's bounding rect (neverheight), so click-position accuracy is completely unaffected by the height change.top-1/2 -translate-y-1/2) already centered relative to the parent's height, so they needed no changes to stay correctly aligned.Test plan
oxlint/oxfmt/fallowclean.