Skip to content

refactor(cli): decompose render phases#2172

Open
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-centralize-process-lifecyclefrom
07-10-refactor-cli-decompose-render-phases
Open

refactor(cli): decompose render phases#2172
jrusso1020 wants to merge 1 commit into
07-10-refactor-cli-centralize-process-lifecyclefrom
07-10-refactor-cli-decompose-render-phases

Conversation

@jrusso1020

@jrusso1020 jrusso1020 commented Jul 10, 2026

Copy link
Copy Markdown
Collaborator

What

Decompose the CLI render command into explicit plan, execute, and present phases.

Why

The monolithic handler mixed validation, environment mutation, rendering, progress, cleanup, and output formatting, making lifecycle bugs and batch JSON corruption easy to introduce.

How

Build an immutable RenderPlan, keep environment changes declarative, execute through one lifecycle boundary, and make presentation emit exactly one final JSON document in batch mode.

Test plan

  • Render-plan and presentation tests; complete CLI suite
  • CLI build, typecheck, and stack-wide validation gates

Copy link
Copy Markdown
Collaborator Author

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 09f8ac2 to 67c643c Compare July 11, 2026 08:53
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 082c25a to 9402771 Compare July 11, 2026 17:05
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch 2 times, most recently from 98c631f to 824aabd Compare July 11, 2026 17:30
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 9402771 to 0900be2 Compare July 11, 2026 17:30
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 824aabd to 986549e Compare July 11, 2026 17:38
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch 2 times, most recently from 6ac2630 to b25135a Compare July 11, 2026 18:04
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 2db5f94 to e503793 Compare July 11, 2026 18:11
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from b25135a to 048e377 Compare July 11, 2026 18:11
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from e503793 to a7b83d2 Compare July 11, 2026 18:16
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 048e377 to 21ec7d3 Compare July 11, 2026 18:16
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from a7b83d2 to aeb6ac3 Compare July 11, 2026 18:21
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 21ec7d3 to 9c9d022 Compare July 11, 2026 18:21
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from aeb6ac3 to 5745dea Compare July 12, 2026 04:01
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 9c9d022 to 494b543 Compare July 12, 2026 04:01
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 5745dea to 95f3b3d Compare July 12, 2026 04:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 494b543 to 991430b Compare July 12, 2026 04:09
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 95f3b3d to e3bcd5a Compare July 12, 2026 04:32
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 991430b to 807e86c Compare July 12, 2026 04:32
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from e3bcd5a to c4d49b9 Compare July 12, 2026 04:58
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 807e86c to 02cb4e2 Compare July 12, 2026 04:58
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from c4d49b9 to d7ee865 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 02cb4e2 to 7cb9533 Compare July 12, 2026 08:54
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from d7ee865 to 59c8c85 Compare July 12, 2026 09:05
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 7cb9533 to 4bf71a5 Compare July 12, 2026 09:05
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-decompose-render-phases branch from 4bf71a5 to 0946378 Compare July 12, 2026 09:11
@jrusso1020 jrusso1020 force-pushed the 07-10-refactor-cli-centralize-process-lifecycle branch from 59c8c85 to 0e1b672 Compare July 12, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant