fix(lint): ignore entrance opacity in scene exit rule#2237
Open
miguel-heygen wants to merge 1 commit into
Open
fix(lint): ignore entrance opacity in scene exit rule#2237miguel-heygen wants to merge 1 commit into
miguel-heygen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
fromTocallsWhy
scene_layer_missing_visibility_killmatched any nearbyopacity: 0. A final scene authored withfromTo(scene, {opacity:0}, {opacity:1})was incorrectly treated as exiting and told to hide itself at the end of the video.How
The rule now recognizes opacity-zero values only in
.to()destination vars or the second destination-vars object of.fromTo(). Entrance-only from-vars no longer trigger the hard-kill requirement.Test plan
bun run --cwd packages/lint test --run src/rules/gsap.test.ts(83/83)