Skip to content

fix(lint): flag videos nested in visual wrappers#2362

Open
miguel-heygen wants to merge 1 commit into
mainfrom
fix/video-wrapper-lint-1783977535
Open

fix(lint): flag videos nested in visual wrappers#2362
miguel-heygen wants to merge 1 commit into
mainfrom
fix/video-wrapper-lint-1783977535

Conversation

@miguel-heygen

Copy link
Copy Markdown
Collaborator

Summary

Wrapped managed videos could pass hyperframes check and then render as solid black because capture only discovers media that are direct children of the host composition root. The media lint now reports any managed <video> nested inside a visual wrapper, including untimed wrappers, before render.

The check uses the parsed HTML parent boundary instead of the previous timed-wrapper heuristic, preserving direct-root videos and avoiding the existing void-element false positive.

Source report: https://heygen.slack.com/archives/C0BGC335AQY/p1783977535307149

Test plan

  • bun test packages/lint/src/rules/media.test.ts — 22 passed
  • bun run --cwd packages/lint test — 363 passed
  • bun run --cwd packages/lint typecheck
  • bun run --cwd packages/lint build
  • Pre-commit lint, format, fallow, and repository typecheck hooks

Compound Engineering
Codex

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant