fix(lint): flag videos nested in visual wrappers#2362
Open
miguel-heygen wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wrapped managed videos could pass
hyperframes checkand then render as solid black because capture only discovers media that are direct children of the host composition root. The media lint now reports any managed<video>nested inside a visual wrapper, including untimed wrappers, before render.The check uses the parsed HTML parent boundary instead of the previous timed-wrapper heuristic, preserving direct-root videos and avoiding the existing void-element false positive.
Source report: https://heygen.slack.com/archives/C0BGC335AQY/p1783977535307149
Test plan
bun test packages/lint/src/rules/media.test.ts— 22 passedbun run --cwd packages/lint test— 363 passedbun run --cwd packages/lint typecheckbun run --cwd packages/lint build