Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added num.isNumberType and repurposed num.isNaN #139

Closed
wants to merge 1 commit into from

Conversation

gphfour
Copy link
Collaborator

@gphfour gphfour commented Jan 10, 2020

Adds num.IsNumberType validator which fixes #138
Re-purposes num.isNaN to reflect its actual function.

@gphfour gphfour requested review from hf and a user January 10, 2020 18:01
@codecov-io
Copy link

codecov-io commented Jan 10, 2020

Codecov Report

Merging #139 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #139   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files           3      3           
  Lines         410    413    +3     
  Branches       56     56           
=====================================
+ Hits          410    413    +3
Impacted Files Coverage Δ
packages/toi/index.ts 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dfdbed8...990f1d7. Read the comment docs.

@gphfour gphfour closed this Apr 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Misleading validator name for num.isNan
2 participants