Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White Spots #493

Closed
wants to merge 3 commits into from
Closed

White Spots #493

wants to merge 3 commits into from

Conversation

RealityRipple
Copy link
Contributor

I've identified 24 emojis with white elements in the background of the glyph. In some cases, it seems more intentional and stylistic, but in all cases, it makes them feel out of place on colored or dark backgrounds.

I've split the list up into things I'm more certain about and less certain about:

  • Emojis in "Set A" have oddly shaped white elements that definitely look out of place.
  • Emojis in "Set B" seem a little more stylistic, but still look wrong on close inspection.
  • Emojis in "Set C" are more "filled-in-holes" and background white. While not visually jarring, they do seem to assume a light background.

This PR is not intended to be directly merged - it's more of a reference. Some of these emojis may be better served with a different approach than just removing the white spots entirely.

These definitely all look out of place on dark backgrounds.
These, I'm not so certain about. Especially the ladder.
More stylistic choices, much less certain. Mostly holes and backgrounds.
@b-g
Copy link
Member

b-g commented Mar 25, 2024

Dear @RealityRipple, many thanks for eagle eyes! I wasn't aware to this "side effect". I'm calling it a side effect, as we are working behind the scenes on making the openmojis finally work as well on a dark background e.g. see #231 (comment) ... hence we've iterated and tweaked all existing openmojis to be dark-mode-ready = so that we can automatically generate a white halo around it. You can test this by uploading an openmoji to our testing app ( https://openmoji-tester.glitch.me) and then running the 3. Check visually (for dark mode) test. Long story short ... we won't be fixing your findings, as these are necessary for the upcoming dark mode support. But if you feel energized, happy to get help on this. All the best.

@RealityRipple RealityRipple deleted the white-spots branch March 30, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants