Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade infrastructure to pixi/uv/ruff, bump minimum python version to 3.11 Develop #2132

Merged
merged 24 commits into from
Feb 15, 2025

Conversation

hgrecco
Copy link
Owner

@hgrecco hgrecco commented Feb 14, 2025

  • Closes # (insert issue number)
  • Executed pre-commit run --all-files with no errors
  • The change is fully covered by automated unit tests
  • Documented in docs/ as appropriate
  • Added an entry to the CHANGES file


jobs:
lint:
runs-on: ubuntu-latest
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Might be a good idea to use os in the matrix so that we define everything in one job.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed, but My I will use this commit to migrate as is, and then use future commits to do this.

- test-py310
- test-py311
- test-py312
- test-py313
numpy: [null, "numpy>=1.23,<2.0.0", "numpy>=2.0.0rc1"]
uncertainties: [null, "uncertainties==3.1.6", "uncertainties>=3.1.6,<4.0.0"]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Dunno if its still relevant to test multiple versions of uncertainties

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure. My suggestion is that we use this commit to migrate as is, and the use future commits to do this.



# TODO: remove this warning after v0.10
class BehaviorChangeWarning(UserWarning):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is dead code I think we can safely remove it

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think so too. The same hapens with certain imports in compat (Self, Never, etc) but I would rather keep it as is until downstream libraries are aware. Again my suggestion is that we use this commit to migrate as is

Copy link

codspeed-hq bot commented Feb 14, 2025

CodSpeed Performance Report

Merging #2132 will not alter performance

Comparing develop (f05be7d) with develop (80b390f)

Summary

✅ 442 untouched benchmarks
🆕 5 new benchmarks
⁉️ 5 dropped benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
⁉️ test_pint_eval[1 + 2 + 5-_plain_tokenizer] 149.7 µs N/A N/A
🆕 test_pint_eval[1 + 2 + 5-plain_tokenizer] N/A 149.9 µs N/A
⁉️ test_pint_eval[1-_plain_tokenizer] 139.2 µs N/A N/A
🆕 test_pint_eval[1-plain_tokenizer] N/A 139.1 µs N/A
⁉️ test_pint_eval[10 m-_plain_tokenizer] 134.2 µs N/A N/A
🆕 test_pint_eval[10 m-plain_tokenizer] N/A 134.2 µs N/A
⁉️ test_pint_eval[10 metros * (5 segundos)-_plain_tokenizer] 157.8 µs N/A N/A
🆕 test_pint_eval[10 metros * (5 segundos)-plain_tokenizer] N/A 157.8 µs N/A
⁉️ test_pint_eval[10 metros + 5 segundos-_plain_tokenizer] 149 µs N/A N/A
🆕 test_pint_eval[10 metros + 5 segundos-plain_tokenizer] N/A 149 µs N/A

matrix:
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"]
environment:
- test-py39
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You've removed support for 3.9 and 3.10 in pyproject.toml.

Maybe keep 3.10 for now according to https://numpy.org/neps/nep-0029-deprecation_policy.html
We can still support it until April 04 2025.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw that you're using 3.11 only features though. Well I'mnot against of moving forward. Only thing might be some downstream that still support 3.10 like Metpy and others.

Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The new Pint version will be released on > April 05, I am not sure if we should. Maybe we can list what would be the burden of keeping Python 3.10

@jules-ch
Copy link
Collaborator

We could remove requirements.txt to since all is handled by pyproject.toml + PEP621 no ?

@hgrecco hgrecco merged commit 2e04c4c into master Feb 15, 2025
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants