Skip to content

HHH-19226 remove support for sql version's older than 2016 #10015

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

MoadElfatihi
Copy link
Contributor

@MoadElfatihi MoadElfatihi commented Apr 13, 2025

Those changes are about removing support for SQL server older than 2016


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19226

@MoadElfatihi MoadElfatihi force-pushed the HHH-19226-remove-support-sqlserver-older-than-2016 branch from cebb2ce to aeec307 Compare April 13, 2025 23:16
@gavinking
Copy link
Member

gavinking commented Apr 14, 2025

A tangential thing I think we should consider also doing: move the Legacy*LimitHandlers, and the SQLServer2005LimitHandler to the community dialects module, since they're no longer used from the supported Dialects.

WDYT @beikov ?

@gavinking
Copy link
Member

https://hibernate.atlassian.net/browse/HHH-19352

@beikov
Copy link
Member

beikov commented Apr 15, 2025

A tangential thing I think we should consider also doing: move the Legacy*LimitHandlers, and the SQLServer2005LimitHandler to the community dialects module, since they're no longer used from the supported Dialects.

WDYT @beikov ?

I agree.

With respect to this PR though, I have to ask you to hold off for now. If you look at the parent issue, these removals are planned for ORM 7.1 at the moment, not 7.0, so this PR may not be merged yet.

@beikov beikov added the 7.1 label Apr 15, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants