HHH-20778 Register BIT DDL type for OracleLegacyDialect - #13176
Open
Daders wants to merge 1 commit into
Open
Conversation
Signed-off-by: dader <shaymardanov.timur@gmail.com>
hibernate-github-bot
Bot
added
the
7.4
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OracleLegacyDialect does not register a DDL type descriptor for SqlTypes.BIT.
OracleBooleanJdbcType uses BIT as its DDL type code. As a result, Boolean mappings can fail during metadata bootstrap because Hibernate cannot resolve the corresponding DDL type.
OracleLegacyDialect already maps BIT to number(1,0) in columnType(), while OracleDialect also registers the corresponding DdlType descriptor.
This change adds the missing BIT -> number(1,0) DDL type registration to OracleLegacyDialect.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
https://hibernate.atlassian.net/browse/HHH-20778