HHH-8585 Fix interceptor exception in beforeTransactionCompletion swallowed instead of aborting commit - #13200
Open
SeanOkafor wants to merge 1 commit into
Open
HHH-8585 Fix interceptor exception in beforeTransactionCompletion swallowed instead of aborting commit #13200SeanOkafor wants to merge 1 commit into
SeanOkafor wants to merge 1 commit into
Conversation
…llowed instead of aborting commit
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://hibernate.atlassian.net/browse/HHH-8585
Exceptions thrown in Interceptor.beforeTransactionCompletion() were being caught and logged but not re-thrown, allowing the transaction to commit despite the interceptor objecting. The exception is now thrown after logging so that it aborts the commit as expected.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.
Please make sure that the following tasks are completed:
Tasks specific to HHH-8585 (Bug):
migration-guide.adocOR check there are no breaking changes