Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HHH-19001 Map ConstraintType to UNIQUE on ConstraintViolationException #9788

Closed
wants to merge 4 commits into from

Conversation

mehmetali2003
Copy link

@mehmetali2003 mehmetali2003 commented Feb 23, 2025

Map ConstraintType to UNIQUE on ConstraintViolationException


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


https://hibernate.atlassian.net/browse/HHH-19001

Map ConstraintType to UNIQUE on ConstraintViolationException
Map ConstraintType to UNIQUE on ConstraintViolationException
Map ConstraintType to UNIQUE on ConstraintViolationException
@mehmetali2003 mehmetali2003 marked this pull request as draft March 1, 2025 12:15
@mehmetali2003 mehmetali2003 marked this pull request as ready for review March 1, 2025 12:19
@mehmetali2003 mehmetali2003 changed the title Hhh 19001 HHH-19001 Mar 1, 2025
@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Mar 1, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [f46ff55]

› This message was automatically generated.

@mehmetali2003 mehmetali2003 changed the title HHH-19001 HHH-19001 Map ConstraintType to UNIQUE on ConstraintViolationException Mar 1, 2025
@gavinking
Copy link
Member

gavinking commented Mar 29, 2025

I was going to merge this, but unfortunately the test fails on all dbs.

I have rolled the change, but not the test into #9932.

@mehmetali2003
Copy link
Author

I was going to merge this, but unfortunately the test fails on all dbs.

I have rolled the change, but not the test into #9932.

Ok, thanks Gavin

@mehmetali2003
Copy link
Author

I was going to merge this, but unfortunately the test fails on all dbs.

I have rolled the change, but not the test into #9932.

Can I merge the test case in file below?
hibernate-core/src/test/java/org/hibernate/orm/test/exception/SQLExceptionConversionTest.java

@gavinking
Copy link
Member

@mehmetali2003 Sure, of course, if you can get it passing.

@gavinking
Copy link
Member

Actually, don't worry about it, I added my own tests as part of work on https://hibernate.atlassian.net/browse/HHH-19300.

Thanks for the contribution, but I'm going to close this one.

@gavinking gavinking closed this Mar 30, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants