Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes where release details live #9919

Merged
merged 3 commits into from
Mar 28, 2025

Conversation

sebersole
Copy link
Member

Changes where various release details live, in conjunction with some website changes -

  • New Features (What's New) are detailed on the website, e.g. https://staging.hibernate.org/orm/releases/7.0/#whats-new. Sometimes links to the Migration Guide
  • Migration Guide no longer lists new features. Sometimes links to parts of the New Features list.
  • Release Notes (GitHub release fragment) simply links to these other places.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


@hibernate-github-bot
Copy link

hibernate-github-bot bot commented Mar 27, 2025

Thanks for your pull request!

This pull request does not follow the contribution rules. Could you have a look?

❌ All commit messages should start with a JIRA issue key matching pattern HHH-\d+
    ↳ Offending commits: [9e38d2c, bd332f1]

› This message was automatically generated.

@@ -1,89 +1,3 @@

### <a name="jpa-32"></a> Jakarta Persistence 3.2
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

more out of curiosity 🙈 where does this file get used? I thought it was for the GH release, but I see that the release scripts have a template for that

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ohh ok 😃 thanks!

soooo maybe we just put these two links directly here:
https://github.com/hibernate/hibernate-release-scripts/blob/7e91caa58015fd3288c65195fb9c7d2be1d40ade/github-release.sh#L150
and then we won't need to update the versions in this md file ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That would change the content for all projects. I did not want to do that (yet).

If y'all feel that is better, by all means feel free. I think projects have a different pattern for the migration-guide url though.

@sebersole sebersole force-pushed the release-details-restructure branch from ca8d8b2 to 617905d Compare March 27, 2025 14:19
@sebersole sebersole force-pushed the release-details-restructure branch from 7b22ab6 to e42dd78 Compare March 28, 2025 15:10
@sebersole sebersole merged commit ee18033 into hibernate:main Mar 28, 2025
20 of 23 checks passed
@sebersole sebersole deleted the release-details-restructure branch March 28, 2025 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants