-
Notifications
You must be signed in to change notification settings - Fork 3.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes where release details live #9919
Changes where release details live #9919
Conversation
@@ -1,89 +1,3 @@ | |||
|
|||
### <a name="jpa-32"></a> Jakarta Persistence 3.2 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
more out of curiosity 🙈 where does this file get used? I thought it was for the GH release, but I see that the release scripts have a template for that
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ohh ok 😃 thanks!
soooo maybe we just put these two links directly here:
https://github.com/hibernate/hibernate-release-scripts/blob/7e91caa58015fd3288c65195fb9c7d2be1d40ade/github-release.sh#L150
and then we won't need to update the versions in this md file ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That would change the content for all projects. I did not want to do that (yet).
If y'all feel that is better, by all means feel free. I think projects have a different pattern for the migration-guide url though.
ca8d8b2
to
617905d
Compare
7b22ab6
to
e42dd78
Compare
Changes where various release details live, in conjunction with some website changes -
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.