Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HSEARCH-5034 Allow passing BeanReference<? extends T> when registering beans to BeanConfigurationContext #3869

Merged
merged 1 commit into from
Dec 15, 2023
Merged

HSEARCH-5034 Allow passing BeanReference<? extends T> when registering beans to BeanConfigurationContext #3869

merged 1 commit into from
Dec 15, 2023

Conversation

yrodiere
Copy link
Member

@yrodiere yrodiere changed the title HSEARCH-5034 Allow passing BeanReference<? extends T> when registering beans to BeancConfigurationContext HSEARCH-5034 Allow passing BeanReference<? extends T> when registering beans to BeanConfigurationContext Dec 13, 2023
marko-bekhta
marko-bekhta approved these changes Dec 13, 2023
View reviewed changes
Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

makes sense 😃 maybe let's build it with the Eclipse compiler as well once it's fixed (knowing how Eclipse one sometimes likes generics 🙈)

@yrodiere
HSEARCH-5034 Allow passing BeanReference<? extends T> when registerin…
d0ebdc9 
…g beans to BeanConfigurationContext

Signed-off-by: Yoann Rodière <[email protected]>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@yrodiere yrodiere added the Waiting for CI Ready to merge once CI passes label Dec 14, 2023
@yrodiere
Copy link
Member Author

Eclipse likes my changes! Merging.
Thanks for the review.

@yrodiere yrodiere merged commit 9b4d99f into hibernate:main Dec 15, 2023
11 checks passed
@yrodiere yrodiere deleted the HSEARCH-5034 branch January 29, 2024 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marko-bekhta marko-bekhta marko-bekhta approved these changes

Assignees
No one assigned
Labels
Waiting for CI Ready to merge once CI passes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yrodiere @marko-bekhta