Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use specific Jenkins nodes for releases #4433

Merged
merged 3 commits into from
Dec 16, 2024

Conversation

yrodiere
Copy link
Member

This should be safer.

It requires moving the snapshot publishing to a dedicated job, but ORM already does that, so we might as well align.

I took this opportunity to clean up sections about CI in CONTRIBUTING.md/MAINTAINERS.md.

We'll need to backport this to all branches where we want to perform releases or publish snapshots...


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license
and can be relicensed under the terms of the LGPL v2.1 license in the future at the maintainers' discretion.
For more information on licensing, please check here.


Copy link
Member

@marko-bekhta marko-bekhta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! This looks like a nice improvement 🎉

ci/snapshot-publish/Jenkinsfile Outdated Show resolved Hide resolved
@yrodiere
Copy link
Member Author

We'll need to backport this to all branches where we want to perform releases or publish snapshots...

Discussed elsewhere, but here's the conclusion. We (or rather @marko-bekhta 😬) will backport:

  • the removal of snapshot publishing in the main Jenkinsfile to all branches
  • the whole patch (except maybe changes to .md files) to still-maintained branches

@marko-bekhta marko-bekhta merged commit 155f61f into hibernate:main Dec 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants