[8.0] HV-2218 Backport JDK 25 jboss-logging fix from HV 9.x - #1985
[8.0] HV-2218 Backport JDK 25 jboss-logging fix from HV 9.x#1985vsalbaba wants to merge 1 commit into
Conversation
|
Thanks for your pull request! This pull request appears to follow the contribution rules. › This message was automatically generated. |
hibernate-github-bot
Bot
changed the title
hibernate-github-bot
Bot
added
the
8.0
c4585f3 to
340b96b
Compare
Upgrade jboss-logging from 3.4.3.Final to 3.6.1.Final and switch to MethodHandles.lookup() variant of getMessageLogger/getBundle to avoid SecurityManager-dependent class lookup removed in JDK 24+. Backport of upstream HV-1974 and HV-2045. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
340b96b to
0e10bb2
Compare
|
hey @vsalbaba 👋🏻 🙂 |
|
As soon as possible would be of course nice. With 8.0.3.SP1 there is a higher chance the fix will make it to downstream product, so 8.0.3.SP1 please. |
|
hey, just a heads up... this needs a bit more work: https://ci.hibernate.org/blue/organizations/jenkins/hibernate-validator/detail/8.0.3.SP/1/pipeline The problem is that the WF version also uses an older version of the logging lib, so the tests won't pass... |
|
hey 👋🏻 so coming back to this one... Hibernate Validator 8.0 seems to run fine with JDK 25 (that is, without applying the changes for the jboss logging): https://ci.hibernate.org/job/hibernate-validator/job/PR-1991/2/stages/?selected-node=68 Was there a particular problem you've run into? |
|
@vsalbaba ping |
|
We've discussed this elsewhere and clarified that the issue comes up when built with JDK25. Hibernate team compiles with JDK17. We've decided we update the compiler plugin and maybe have a different test profile for the new WF version that can run on JDK 25. |
2 participants
https://hibernate.atlassian.net/browse/HV-2218
Summary
Backport of upstream fixes from
mainto HV 8.0.x for JDK 25 compatibility.HV 8.0.x uses the deprecated
Logger.getMessageLogger(Class, String)andMessages.getBundle(Class)APIs from jboss-logging 3.4.3.Final, which rely onSecurityManager-based class lookup. JDK 24 removedSecurityManager, causing "implementation not found" errors on JDK 25.This was already fixed upstream in
main/ HV 9.x but never backported to 8.0.x.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
For more information on licensing, please check here.