todo updates

Signed-off-by: Atanas Atanasov <[email protected]>
hiero-ledger · Mar 5, 2025 · 6cfa076 · 6cfa076
1 parent f100092
commit 6cfa076
Showing 1 changed file with 4 additions and 4 deletions.
diff --git a/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java b/server/src/main/java/com/hedera/block/server/ack/AckHandlerImpl.java
@@ -70,10 +70,11 @@ public void blockPersisted(@NonNull final BlockPersistenceResult blockPersistenc
                 final BlockInfo info = blockInfo.computeIfAbsent(blockNumber, BlockInfo::new);
                 info.getBlockStatus().setPersisted();
             } else {
-                // @todo(743) handle other cases for the blockPersistenceResult
+                // @todo(774) handle other cases for the blockPersistenceResult
                 //   for now we will simply send an end of stream message
                 //   but more things need to be handled, like ensure the
-                //   blockInfo map will not be inserted
+                //   blockInfo map will not be inserted. We should use a
+                //   persistence failed response code as well.
                 blockVerificationFailed(blockNumber);
                 blockInfo.remove(blockNumber);
             }
@@ -159,8 +160,7 @@ private void attemptAcks() {
                     //   remove the info from the map. This means that the data needs to be requested
                     //   again. What would be the best way to hande inability to move the block with
                     //   the limitations we current have?
-                    // @todo(743) we should think of a response code for unsuccessful persistence
-                    //   this is outside of the scope of this PR
+                    // @todo(774) we should use a response code for failed persistence here
                     blockVerificationFailed(nextBlock);
                     return;
                 }