Introduce a Block Persistence Failure response code

[ata-nas]

Persona

As a Block Node Developer/Operator/User/Client

Request

I want to send a failed persistence response code to publishers

Goal

So that I report that persistence has failed

Technical Notes

• as of today there is no persistence failure PublishStreamResponseCode
• as a fallback, today we use the bad state proof if persistence fails
• we need to introduce a block persistence failure response code

[jsync-swirlds]

PR here to update in services.
Change to published protobufs will happen after release 61 is synchronized to hedera-protobufs (or possibly via some other mechanism if the publication method changes).

[ata-nas]

@jsync-swirlds FYI, places where changes need to be made (be chosen the correct response code to publish) in the codebase currently are tagged with @todo(743) within PR #715. These are in addition to the introduction of the response code itself.

[jsync-swirlds]

@jsync-swirlds FYI, places where changes need to be made (be chosen the correct response code to publish) in the codebase currently are tagged with @todo(743) within PR #715. These are in addition to the introduction of the response code itself.

Good point. I think I'll split out a separate task for that, so the work in other repos is separate from the work in block node repo.

[Nana-EC]

@jsync-swirlds moving this to ongoing sprint since it's active but left in old sprint

[Nana-EC]

@jsync-swirlds PR on services side was merged, what's the next step here or can this be closed assuming BN logic already has logic to send error code?

[jsync-swirlds]

I was just leaving open to track that we see the updates in protobufs. It's closed from a work-to-do perspective (Block Node code changes are in a separate issue).
That's also why I left the old sprint, as all the work was done in that sprint. We should probably have a team guideline on when to update sprint/when not to.