feat: S3Client Cleanup and Error Handling Improvements

[ata-nas]

Reviewer Notes

• some cleanups for the S3 client
• I have removed the xml handler as it was creating some issues (or rather, was not flexible enough)
  • we cannot rely on Content-Lenght header to determine if there is a body or not unfortunately. It is not consistent.
  • some requests are not expected to have a body if successful, but will have if an error occurs. We need more flexibility to be able to dynamically parse or not a body.
• currently tested with AWS S3, will test also with GCP
  • GCP should be compatible (request wise), the hope is that the same client can be reused (maybe authorization header will be different)

Related Issue(s)

Closes #1118
Closes #1074

[ata-nas]

Just some general questions. I have generally added some cleanup, a couple of new methods. I have tested with AWS S3, it is all working properly. GCP to follow. Collecting early feedback. Going back and forth on how to utilize the checked exceptions to do some error handling. Opted to remove the xml handler as it was causing issues: we cannot rely on the "Content-Length" header to determine if there is a body. Also the handler is not flexible enough for our needs, there are some requests that have no body if successful, but will have an xml body if the request fails (3xx+ response), and the handler will throw if no body or no xml body.

PLEASE NOTE: I have not yet gotten to testing the plugin itself. I have tested the client only. I will test the plugin itself as well, but will have to update with results. Also, more tests are to be added, have not gotten to that as well as of now.

[georgi-l95]

Did one round, will do another when tests are added. Solid progress 🙌

[ata-nas]

UPDATE:
As we discussed with the team, let's proceed with what we have:

1. The client is validated, working with AWS and GCP alike
2. We have introduced basic error handling, but we will need to improve it
3. We have done some cleanup and some test improvements

See the parent of the issue this PR closes (#1105) for other related issues that describe what needs to be done as a follow up.

[AlfredoG87]

LGTM 👍

[AlfredoG87]

LG!

[codecov]

Codecov Report

Attention: Patch coverage is 45.28302% with 145 lines in your changes missing coverage. Please review.

Files with missing lines	Patch %	Lines
.../hiero/block/node/base/s3/S3ResponseException.java	0.00%	72 Missing ⚠️
...in/java/org/hiero/block/node/base/s3/S3Client.java	67.79%	46 Missing and 11 partials ⚠️
...rg/hiero/block/node/base/s3/S3ClientException.java	0.00%	8 Missing ⚠️
.../node/base/s3/S3ClientInitializationException.java	0.00%	8 Missing ⚠️

@@             Coverage Diff              @@
##               main    #1149      +/-   ##
============================================
- Coverage     84.26%   82.11%   -2.16%     
- Complexity      915      917       +2     
============================================
  Files           105      107       +2     
  Lines          3743     3986     +243     
  Branches        413      427      +14     
============================================
+ Hits           3154     3273     +119     
- Misses          422      539     +117     
- Partials        167      174       +7     

Files with missing lines	Coverage Δ	Complexity Δ
.../org/hiero/block/common/utils/StringUtilities.java	100.00% <ø> (ø)	3.00 <0.00> (ø)
...rg/hiero/block/node/base/s3/S3ClientException.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
.../node/base/s3/S3ClientInitializationException.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)
...in/java/org/hiero/block/node/base/s3/S3Client.java	77.24% <67.79%> (-6.40%)	41.00 <24.00> (+4.00)	⬇️
.../hiero/block/node/base/s3/S3ResponseException.java	0.00% <0.00%> (ø)	0.00 <0.00> (?)

... and 6 files with indirect coverage changes

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.