Skip to content

chore: Small Helm and project improvements #1162

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 19, 2025
Merged

Conversation

AlfredoG87
Copy link
Contributor

@AlfredoG87 AlfredoG87 commented May 17, 2025

Reviewer Notes

  1. improving consumer override value, to avoid permission denied issue when deploying.

  2. adding mid-size.yaml for medium size deployments, usually what we deploy on dev k8 env.

  3. extra housekeeping of the settings.gradle.kts file, so it matches 1-1 with the modules, keeps consistent aliases, and also are shown in the same order (alphabetical) so is easier to compare the 2 in the future

Fixes #1161

…hen deploying.

adding mid-size.yaml for medium size deployments, usually what we deploy on dev k8 env.

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
… with the modules, keeps consistent aliases, and also are shown in the same order (alphabetical) so is easier to compare the 2 in the future

Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
@AlfredoG87 AlfredoG87 self-assigned this May 17, 2025
@AlfredoG87 AlfredoG87 added this to the 0.11.0 milestone May 17, 2025
@AlfredoG87 AlfredoG87 added Helm - Deploy Improvement Code changes driven by non business requirements labels May 17, 2025
@AlfredoG87 AlfredoG87 marked this pull request as ready for review May 17, 2025 00:19
@AlfredoG87 AlfredoG87 requested review from a team as code owners May 17, 2025 00:19
Copy link
Contributor

@Nana-EC Nana-EC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, 1 clarifcation

@Nana-EC Nana-EC requested review from jsync-swirlds and removed request for mattp-swirldslabs May 19, 2025 18:35
Copy link
Contributor

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one note for an item we might want to remove (in a separate issue).

@AlfredoG87 AlfredoG87 merged commit 188187a into main May 19, 2025
17 checks passed
@AlfredoG87 AlfredoG87 deleted the 1161-small-improvements branch May 19, 2025 21:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Helm - Deploy Improvement Code changes driven by non business requirements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Various Improvements for deployment
3 participants