Skip to content

feat: Improve blockIsEnding and shutdown of Publisher#2505

Merged
jsync-swirlds merged 1 commit intomainfrom
2344-improve-blockisending-and-shutdown-of-publisher
Apr 14, 2026
Merged

feat: Improve blockIsEnding and shutdown of Publisher#2505
jsync-swirlds merged 1 commit intomainfrom
2344-improve-blockisending-and-shutdown-of-publisher

Conversation

@ata-nas
Copy link
Copy Markdown
Contributor

@ata-nas ata-nas commented Apr 2, 2026 •
edited
Loading

Reviewer Notes

  • Centralized publisher request results
  • Improvements for shutdown
    • Manager schedules shutdowns instead of forcing them
  • Send SKIP instead of END_ERROR in getActionForCurrentlyStreaming
  • Receiving an EndOfBlock for block the manager no longer needs still allows a RESEND to possibly be sent as a response

Related Issue(s)

Closes #1949
Closes #2344
Closes #2339

@ata-nas ata-nas added this to the 0.32.0 milestone Apr 2, 2026
@ata-nas ata-nas requested a review from jsync-swirlds April 2, 2026 14:50
@ata-nas ata-nas self-assigned this Apr 2, 2026
@ata-nas ata-nas added the pull request label to get past the "label required" check when no label is needed or appropriate. label Apr 2, 2026
@ata-nas ata-nas linked an issue Apr 2, 2026 that may be closed by this pull request
Improve blockIsEnding and shutdown of Publisher #2344
Closed
@codacy-production
Copy link
Copy Markdown

codacy-production Bot commented Apr 2, 2026 •
edited
Loading

Not up to standards ⛔

🔴 Issues 1 medium

Alerts:
⚠ 1 issue (≤ 0 issues of at least minor severity)

Results:
1 new issue

Category Results
Complexity 1 medium

View in Codacy

🟢 Metrics 25 complexity · 0 duplication

Metric Results
Complexity 25
Duplication 0

View in Codacy

TIP This summary will be updated as you push new changes. Give us feedback

@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch 6 times, most recently from 52d965f to 833b149 Compare April 3, 2026 10:43
@ata-nas ata-nas marked this pull request as ready for review April 3, 2026 10:46
@ata-nas ata-nas requested review from a team as code owners April 3, 2026 10:46
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch 2 times, most recently from c5cfe40 to ba3e845 Compare April 3, 2026 11:05
jsync-swirlds
jsync-swirlds reviewed Apr 6, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@jsync-swirlds jsync-swirlds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for the delay reviewing this.
There are a few areas where we can make some significant improvements.

Comment thread ...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Comment thread ...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Comment thread ...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Comment thread ...ublisher/src/main/java/org/hiero/block/node/stream/publisher/LiveStreamPublisherManager.java
Comment thread ...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java Outdated
Comment thread ...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java Outdated
Comment thread ...e/stream-publisher/src/main/java/org/hiero/block/node/stream/publisher/PublisherHandler.java Outdated
@jsync-swirlds jsync-swirlds mentioned this pull request Apr 7, 2026
Merged
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch from ba3e845 to 0e12892 Compare April 7, 2026 07:07
@ata-nas ata-nas requested a review from jsync-swirlds April 7, 2026 10:47
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch from 862bf61 to e1f4e6a Compare April 7, 2026 17:05
@ata-nas ata-nas mentioned this pull request Apr 7, 2026
Open
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch 2 times, most recently from 073dbda to a2a3857 Compare April 8, 2026 07:22
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch 2 times, most recently from 7a1c3dd to ed9e5b0 Compare April 8, 2026 11:49
@ata-nas ata-nas requested a review from jsync-swirlds April 9, 2026 15:47
@ata-nas ata-nas mentioned this pull request Apr 9, 2026
Open
jsync-swirlds
jsync-swirlds previously approved these changes Apr 10, 2026
View reviewed changes
AlfredoG87
AlfredoG87 previously approved these changes Apr 13, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just needs a rebase before merging.

Nana-EC
Nana-EC previously approved these changes Apr 14, 2026
View reviewed changes
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch from bb16337 to 41cacb8 Compare April 14, 2026 08:06
@ata-nas ata-nas dismissed stale reviews from Nana-EC, jsync-swirlds, and AlfredoG87 via 77c61c0 April 14, 2026 08:10
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch 2 times, most recently from 77c61c0 to bb4c2c5 Compare April 14, 2026 08:14
@ata-nas
feat: Improve blockIsEnding and shutdown of Publisher
63e3fca 
* Centralized publisher request results
* Improvements for shutdown
  * Manager schedules shutdowns instead of forcing them
* Send SKIP instead of END_ERROR in `getActionForCurrentlyStreaming`
* Receiving an EndOfBlock for block the manager no longer needs still allows a RESEND to possibly be sent as a response

Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
@ata-nas ata-nas force-pushed the 2344-improve-blockisending-and-shutdown-of-publisher branch from bb4c2c5 to 63e3fca Compare April 14, 2026 09:49
AlfredoG87
AlfredoG87 approved these changes Apr 14, 2026
View reviewed changes
Copy link
Copy Markdown
Contributor

@AlfredoG87 AlfredoG87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsync-swirlds jsync-swirlds merged commit 2b05667 into main Apr 14, 2026
16 of 17 checks passed
@jsync-swirlds jsync-swirlds deleted the 2344-improve-blockisending-and-shutdown-of-publisher branch April 14, 2026 18:23
ivannov pushed a commit to ivannov/hiero-block-node that referenced this pull request Apr 20, 2026
@ata-nas @ivannov
feat: Improve blockIsEnding and shutdown of Publisher (hiero-ledg…
eb5a996 
…er#2505)

* Centralized publisher request results
* Improvements for shutdown
  * Manager schedules shutdowns instead of forcing them
* Send SKIP instead of END_ERROR in `getActionForCurrentlyStreaming`
* Receiving an EndOfBlock for block the manager no longer needs still allows a RESEND to possibly be sent as a response

Signed-off-by: Atanas Atanasov <a.v.atanasov98@gmail.com>
@AlfredoG87 AlfredoG87 added the Improvement Code changes driven by non business requirements label Apr 28, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 28, 2026

Codecov Report

❌ Patch coverage is 94.11765% with 8 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
.../block/node/stream/publisher/PublisherHandler.java 93.89% 8 Missing ⚠️ 
@@             Coverage Diff              @@
##               main    #2505      +/-   ##
============================================
+ Coverage     81.49%   81.68%   +0.18%     
+ Complexity     1528     1522       -6     
============================================
  Files           139      139              
  Lines          7162     7186      +24     
  Branches        756      751       -5     
============================================
+ Hits           5837     5870      +33     
+ Misses         1009     1001       -8     
+ Partials        316      315       -1
Files with missing lines Coverage Δ Complexity Δ
...e/stream/publisher/LiveStreamPublisherManager.java 84.33% <100.00%> (-0.18%) 69.00 <0.00> (ø)
.../block/node/stream/publisher/PublisherHandler.java 92.82% <93.89%> (+0.83%) 71.00 <9.00> (-6.00) ⬆️

... and 1 file with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jsync-swirlds jsync-swirlds jsync-swirlds approved these changes

@AlfredoG87 AlfredoG87 AlfredoG87 approved these changes

@Nana-EC Nana-EC Nana-EC left review comments

@berryware berryware Awaiting requested review from berryware

@ivannov ivannov Awaiting requested review from ivannov

@rockysingh rockysingh Awaiting requested review from rockysingh

Assignees

@ata-nas ata-nas

Labels

Improvement Code changes driven by non business requirements pull request label to get past the "label required" check when no label is needed or appropriate.

Projects

None yet

Milestone

0.32.0

Development

Successfully merging this pull request may close these issues.

Improve blockIsEnding and shutdown of Publisher Improve Sending of BAD_BLOCK_PROOF in Manager Revisit blockIsEnding Method Usage

4 participants

@ata-nas @Nana-EC @jsync-swirlds @AlfredoG87