fix: Various Bugs found on 0.6.0-rc1 deployment.
#817
Merged
+153
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlfredoG87
added
the
Bug
jsync-swirlds
previously approved these changes
Mar 10, 2025
… to avoid using the root of the PVC. - Update of ownership and permissions for both the live-data and archive-data sub-paths inside their respective PVCs - When Mounting the values to the path of the BlockNode Server, using the corresponding created sub-path on each PVC. Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
…to Optional.ofNullable, so it returns Optional.Empty when blockHash is Null. Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
AlfredoG87
force-pushed
the
060rc1-bug-fixes
branch
from
f2a9d4f to
b672a8e
Compare
jsync-swirlds
approved these changes
Mar 11, 2025
ata-nas
approved these changes
Mar 11, 2025
Codecov ReportAll modified and coverable lines are covered by tests ✅ @@ Coverage Diff @@
## main #817 +/- ##
============================================
+ Coverage 89.12% 89.19% +0.06%
- Complexity 710 712 +2
============================================
Files 130 130
Lines 3045 3045
Branches 219 219
============================================
+ Hits 2714 2716 +2
+ Misses 265 264 -1
+ Partials 66 65 -1
🚀 New features to boost your workflow:
|
AlfredoG87
added a commit
that referenced
this pull request
Mar 11, 2025
Signed-off-by: Alfredo Gutierrez Grajeda <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reviewer Notes
At the beginning of the sprint we decided to include a first/simple mechanism to recover from restarts, so that we can keep re-using
metrics, logs and datafrom the next deployment forward. This meant adding aInternal Memoryfeature and Helm PVCs and its corresponding mappings and values so that botharchiveandlivedata were pesisted.However, 3 bugs were found with the first
rcversion:Fixes #815
Fixes #816
Fixes #814