Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update publish to use environment #42

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

ryjones
Copy link
Contributor

@ryjones ryjones commented Jan 31, 2025

No description provided.

@ryjones ryjones force-pushed the trusted-publisher branch 3 times, most recently from ec92523 to 8243b08 Compare January 31, 2025 18:24
@ryjones ryjones marked this pull request as draft January 31, 2025 18:26
jwagantall
jwagantall previously approved these changes Jan 31, 2025
Copy link

@jwagantall jwagantall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to move PYPI_API_TOKEN to the pypi environment secrets?

@jwagantall jwagantall dismissed their stale review January 31, 2025 20:14

I believe we still need the token to be defined right? just we need to move it into the pypi environment

@ryjones
Copy link
Contributor Author

ryjones commented Jan 31, 2025

Do we want to move PYPI_API_TOKEN to the pypi environment secrets?

No

@ryjones ryjones marked this pull request as ready for review February 5, 2025 12:27
@rbair23 rbair23 merged commit 00625c4 into main Feb 5, 2025
4 checks passed
@rbair23 rbair23 deleted the trusted-publisher branch February 5, 2025 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants