Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pytest to the github workflow. #48

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Add pytest to the github workflow. #48

merged 1 commit into from
Feb 5, 2025

Conversation

rbair23
Copy link
Contributor

@rbair23 rbair23 commented Feb 5, 2025

I had problems with two type annotations that failed to compile. I removed these in this change, and we can (and should) add them back in when we have a solution.

@rbair23 rbair23 requested a review from nadineloepfe February 5, 2025 20:48
@rbair23 rbair23 force-pushed the 00047-CI-PyTest branch 2 times, most recently from ea5dd0c to d8d83ef Compare February 5, 2025 21:05
I had problems with two type annotations that failed to
compile. I removed these in this change, and we can
(and should) add them back in when we have a
solution.

Signed-off-by: Richard Bair <[email protected]>
Signed-off-by: Richard Bair <[email protected]>
@rbair23
Copy link
Contributor Author

rbair23 commented Feb 5, 2025

I had to remove the type definitions for public_key and private_key init methods because of this error:

➜  hiero-sdk-python git:(00047-CI-PyTest) ✗ uv run pytest
ImportError while loading conftest '/Users/richardbair/Projects/hiero/hiero-sdk-python/tests/conftest.py'.
tests/conftest.py:3: in <module>
    from hiero_sdk_python.account.account_id import AccountId
src/hiero_sdk_python/__init__.py:10: in <module>
    from .crypto.private_key import PrivateKey
src/hiero_sdk_python/crypto/private_key.py:7: in <module>
    class PrivateKey:
src/hiero_sdk_python/crypto/private_key.py:12: in PrivateKey
    def __init__(self, private_key: ec.EllipticCurvePrivateKey | ed25519.Ed25519PrivateKey):
E   TypeError: unsupported operand type(s) for |: 'ABCMeta' and 'ABCMeta'

@rbair23 rbair23 merged commit 8d386ec into main Feb 5, 2025
4 checks passed
@rbair23 rbair23 deleted the 00047-CI-PyTest branch February 5, 2025 21:17
@rbair23 rbair23 linked an issue Feb 6, 2025 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The continuous build should run pytest
1 participant