feat: PR checks #56
Merged
feat: PR checks #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
Signed-off-by: nadine.loepfe <[email protected]>
exploreriii
reviewed
Feb 20, 2025
There was a problem hiding this comment.
a)Suggested @ Readme, from line 620:
1. Volunteer and get assigned to an open issue.
2. Fork this repository.
3. Create a new branch with your feature or fix.
4. Make your changes and follow commit naming procedures.
5. Ensure the tests pass.
6. Ensure commits are squashed and GPG-signed
7. Submit a pull request
Would also suggest some guidance on squashing, signing and naming in readme (maybe a separate contribute readme).
Can be done separately. I can raise PR if desired. Would suggest a readme users and readme for contributors.
b) is contents: write permission necessary for title checks?
|
hey @exploreriii ! that's on another branch, to keep things separate. |
Signed-off-by: nadine.loepfe <[email protected]>
exploreriii
approved these changes
Feb 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.