Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow quoting full messages when replying #245

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

blastrock
Copy link
Contributor

This adds a configuration option quote_messages which allows quoting full messages when replying to a message in Matrix.

Disabled (default, and current behavior):

<alice> hello
<bob> alice: hi

Enabled:

<alice> hello
<bob> > alice: hello
<bob> hi

I find that when there are a lot of people talking on a channel, or when answering an old message, quoting it fully makes more sense than just mentioning the author.

Since I didn't want to change the behavior too much, I kept the current behavior as the default, but I suggest we change the default to the new behavior (or even remove the config option and make it the only behavior...?).

@roughnecks
Copy link

I would personally really like to see this merged.

@hifi
Copy link
Owner

hifi commented Oct 30, 2022

Would be nice(r) to have it in the style of #214 so it's a general reply quote configuration that could have more states than two but I'd like to keep the original behavior at least for now as the default.

Otherwise I'm good with merging this.

@blastrock
Copy link
Contributor Author

So, would you prefer something like

REPLYBEHAVIOR ( --mention-author | --quote-message )

? Tell me if you prefer different names :)

I think I'll also change the quoting style to something more irc-y as explained in the issue, without option to choose the style

<bob> <alice> hello
<bob> hi

If that's fine with you

@hifi
Copy link
Owner

hifi commented Oct 31, 2022

Sounds good!

Maybe REPLYMODE (--mention | --quote) so it's a bit more concise?

One thing I noticed just now was that this needs to be a network level setting (unfortunately) as setting and enforcing a global mode for shared Heisenbridges isn't ideal. It's also not ideal that you need to reconfigure it per each network but it's better than forcing everyone to use a single style.

@blastrock
Copy link
Contributor Author

All done. This is now a network setting only, with the naming you proposed. I kept the default as mention and used the IRC-style quoting.

@blastrock
Copy link
Contributor Author

Hello,

Do you think this could be merged? This is still a feature I miss regularly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants