Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lint tests #85

Merged
merged 3 commits into from
May 24, 2019
Merged

Lint tests #85

merged 3 commits into from
May 24, 2019

Conversation

mccalluc
Copy link
Contributor

Description

What was changed in this pull request?

  • Add to the list of files we can run flake8 against without any rules disabled.
  • In many cases we assign to a variable, and then fail to make any assertions: TODOs have been added in the code.
  • I was also prompted to file turn on test_bedarcsdb_tiles1? #84, where we have a lot of assertions, but they've been commented out.

Checklist

  • Unit tests added or updated
  • Updated CHANGELOG.md

@mccalluc
lint tests
9784a2f 
(Common problem is assigning to a variable, and then not making any assertions.)
@mccalluc mccalluc requested a review from pkerpedjiev May 21, 2019 20:39
@pkerpedjiev pkerpedjiev merged commit ae193e1 into develop May 24, 2019
@pkerpedjiev pkerpedjiev deleted the mccalluc/yay-more-linting branch May 24, 2019 05:03
@pkerpedjiev pkerpedjiev restored the mccalluc/yay-more-linting branch May 24, 2019 05:03
@pkerpedjiev pkerpedjiev deleted the mccalluc/yay-more-linting branch May 24, 2019 05:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkerpedjiev pkerpedjiev pkerpedjiev approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mccalluc @pkerpedjiev