Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow file pointers in tileset loaders #161

Merged
merged 6 commits into from
Jan 23, 2025
Merged

Allow file pointers in tileset loaders #161

merged 6 commits into from
Jan 23, 2025

Conversation

pkerpedjiev
Copy link
Member

Description

What was changed in this pull request?

  • Allows file pointers in tileset loaders by automatically calculating a track uuid based on the hash of the pointer

Why is it necessary?

  • So that we can pass in file pointers rather than string filepaths

Fixes #___

Checklist

  • Unit tests added or updated
  • Documentation added or updated
  • Updated CHANGELOG.md

nvictus
nvictus reviewed Jan 23, 2025
View reviewed changes
src/higlass/tilesets.py Outdated Show resolved Hide resolved
nvictus
nvictus reviewed Jan 23, 2025
View reviewed changes
src/higlass/tilesets.py Outdated Show resolved Hide resolved
nvictus
nvictus reviewed Jan 23, 2025
View reviewed changes
src/higlass/tilesets.py Outdated Show resolved Hide resolved
@nvictus nvictus merged commit 66b8fd6 into main Jan 23, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nvictus nvictus nvictus left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pkerpedjiev @nvictus