Support composer 2 #220
Support composer 2 #220
Conversation
| @@ -63,6 +63,10 @@ public function activate(Composer $composer, IO\IOInterface $io) | |||
| } | |||
| // @codeCoverageIgnoreEnd | |||
|
|
|||
| if (!defined('\Composer\Installer\InstallerEvents::POST_DEPENDENCIES_SOLVING')) { | |||
There was a problem hiding this comment.
What is the reason for this condition?
There was a problem hiding this comment.
It indicates that composer 2 is used (as stated)? :)
There was a problem hiding this comment.
But for this PluginInterface::PLUGIN_API_VERSION was introduced.
| @@ -97,6 +101,9 @@ class_exists(__NAMESPACE__ . '\\' . $class); | |||
|
|
|||
| public static function getSubscribedEvents() | |||
| { | |||
| if (!defined('\Composer\Installer\InstallerEvents::POST_DEPENDENCIES_SOLVING')) { | |||
There was a problem hiding this comment.
What is the reason for this condition?
|
This is important now as I have CI builds failing now that https://github.com/composer/composer/releases/tag/2.0.0 is released. |
|
@heddn depending on your setup you could remove this plugin from your CI pipeline as composer 2 natively downloads necessary files in parallel |
|
I can and will, but I have several legacy jobs that haven't updated yet and a simple fix here would let them continue to run without interruption. |
|
I won't fix this plugin anymore, just use Composer 2. |
This fixes #218
I just disabled the plugin when a certain class constant was removed (indicating that composer 2 is used).