fix: make MockSignature signature field public #1595
Merged
+100
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
|
Do you still need that @rafaelcr? |
hugocaillard
force-pushed
the
rafaelcr-patch-1
branch
from
2ea8e2a to
2d59a0e
Compare
|
Yep @hugocaillard we only need it for the Signer Metrics API via Chainhook but we do need to be able to get this field as public |
|
@rafaelcr Ok good, can you just run cargo format on the PR please? |
hugocaillard
force-pushed
the
rafaelcr-patch-1
branch
from
2d59a0e to
0dc834a
Compare
hugocaillard
force-pushed
the
rafaelcr-patch-1
branch
from
0dc834a to
322dec3
Compare
hugocaillard
force-pushed
the
rafaelcr-patch-1
branch
from
3550fad to
6086a60
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.