Skip to content

Increase Rosetta Test Coverage #1141

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 11, 2022
Merged

Increase Rosetta Test Coverage #1141

merged 1 commit into from
Apr 11, 2022

Conversation

MHassanTariq
Copy link
Contributor

Description

This PR is a continuation of PR #1011. It adds test cases for Rosetta apis to increase code coverage for Rosetta tests.

For details refer to issue #985

Type of Change

  • New feature
  • Bug fix
  • API reference/documentation update
  • Other

Checklist

  • Code is commented where needed
  • Unit test coverage for new or modified code paths
  • npm run test passes
  • Changelog is updated
  • Tag 1 of @rafaelcr or @zone117x for review

@MHassanTariq MHassanTariq self-assigned this Apr 8, 2022
@github-actions
Copy link

github-actions bot commented Apr 8, 2022

🚀 Deployed on https://deploy-preview-1141--stacks-blockchain-api.netlify.app

@github-actions github-actions bot temporarily deployed to pull request April 8, 2022 00:03 Inactive
@MHassanTariq MHassanTariq marked this pull request as ready for review April 11, 2022 06:53
@MHassanTariq MHassanTariq requested a review from rafaelcr April 11, 2022 06:53
rafaelcr
rafaelcr approved these changes Apr 11, 2022
View reviewed changes
Copy link
Collaborator

@rafaelcr rafaelcr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MHassanTariq LGTM

@rafaelcr rafaelcr merged commit cb1ec6b into develop Apr 11, 2022
@rafaelcr rafaelcr deleted the increase_rosetta_coverage branch April 11, 2022 15:16
@blockstack-devops
Copy link

🎉 This PR is included in version 4.0.0-beta.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@blockstack-devops
Copy link

🎉 This PR is included in version 4.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rafaelcr rafaelcr rafaelcr approved these changes

Assignees

@MHassanTariq MHassanTariq

Labels
released on @beta released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MHassanTariq @blockstack-devops @rafaelcr