LYNX-722: Style desktop navigation menu in boilerplate #307
Conversation
|
Hello, I'm the AEM Code Sync Bot and I will run some actions to deploy your branch and validate page speed.
|
svera
changed the title
|
@svera please resolve lint issues. If you cannot access the build failure log, let me know. |
svera
changed the title
svera
changed the title
| @@ -175,10 +175,20 @@ header nav .nav-sections ul > li > a { | |||
|
|
|||
| header nav .nav-sections ul > li > ul { | |||
| margin-top: 0; | |||
| width: 300px; | |||
There was a problem hiding this comment.
are we sure that it should be 300px? or should we use a variable/configuration?
| } | ||
|
|
||
| header nav .nav-sections ul > li > ul > li { | ||
| font-weight: 400; | ||
| width: 300px; |
There was a problem hiding this comment.
are we sure that it should be 300px? or should we use a variable/configuration?
| position: absolute; | ||
| left: -24px; | ||
| width: 200px; | ||
| width: 900px; |
There was a problem hiding this comment.
have you tested what happens if we have several items inside a category?
There was a problem hiding this comment.
@loginesta how are you seeing all these items? I cannot see them in https://lynx-722--aem-boilerplate-commerce--hlxsites.aem.live/
There was a problem hiding this comment.
I have manually added them editing the DOM in order to see the behaviour of the Site Navigation in the browser
| header nav .nav-sections ul > li > ul, | ||
| header nav .nav-sections ul > li > ul > li { | ||
| width: 100%; | ||
| } |
There was a problem hiding this comment.
I am sure we need more styling for mobile using media queries.
it looks poor as it looks at the moment...
Test URLs: