[ALS-7674] Remove Facet Reset #344
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
srpiatt
commented
Jan 23, 2025
•
srpiatt
commented
- Allow search button on empty search.
…kerfile to build node modules folder for linux.
srpiatt
force-pushed
the
feature/ALS-7674
branch
2 times, most recently
from
1c11689 to
1bfa2e4
Compare
srpiatt
force-pushed
the
feature/ALS-7674
branch
from
1bfa2e4 to
8d9526b
Compare
|
@JamesPeck Technically, it will function fine because there's no outer form tag to drive the form submission. But it could be bad for aria and accessibility, so I'll remove it. Good catch. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.