Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Buggy] Fix leaking streams (id from gui side) #587

Draft
wants to merge 33 commits into
base: main
Choose a base branch
from
Draft

Conversation

maidh91
Copy link
Member

@maidh91 maidh91 commented Feb 1, 2025

Issue

  • flow: preload.messages() => gui.messages() => sidecar.messages()
  • in preload,
    • sub = messages(patternFoo)
    • when calling sub.end/close, gui still subscribes patternFoo to sidecar
    • then if calling sub2 = messages(patternFoo) again
    • sub2.on(data) will receive 2 messages per event

=> sub2 should receive 1 message per event only, but because gui never unsub, so preload will receive duplicate messages

ref.

@maidh91 maidh91 changed the title Fix zombie gui messages Fix leaking gui messages Feb 1, 2025
@maidh91 maidh91 changed the title Fix leaking gui messages Fix leaking streams in gui Feb 3, 2025
@maidh91 maidh91 changed the title Fix leaking streams in gui Fix leaking streams in gui (approach #1) Feb 3, 2025
@maidh91 maidh91 changed the title Fix leaking streams in gui (approach #1) Fix leaking streams in gui (use id in gui) Feb 3, 2025
@maidh91 maidh91 changed the title Fix leaking streams in gui (use id in gui) Fix leaking streams (id from gui side) Feb 3, 2025
@maidh91 maidh91 changed the title Fix leaking streams (id from gui side) [Buggy] Fix leaking streams (id from gui side) Feb 3, 2025
@maidh91 maidh91 marked this pull request as draft February 3, 2025 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant